/[resiprocate]/main/resip/dum/InviteSession.cxx
ViewVC logotype

Diff of /main/resip/dum/InviteSession.cxx

Parent Directory Parent Directory | Revision Log Revision Log | View Patch Patch

revision 4691 by sgodin, Thu May 19 13:10:59 2005 UTC revision 5001 by sgodin, Tue Jun 28 18:54:52 2005 UTC
# Line 240  Line 240 
240           mProposedLocalSdp = InviteSession::makeSdp(offer);           mProposedLocalSdp = InviteSession::makeSdp(offer);
241           break;           break;
242    
243        // !slg! Can we handle all of the states listed in isConnected() ???        // ?slg? Can we handle all of the states listed in isConnected() ???
244        default:        default:
245           WarningLog (<< "Can't provideOffer when not in Connected state");           WarningLog (<< "Can't provideOffer when not in Connected state");
246           throw DialogUsage::Exception("Can't provide an offer", __FILE__,__LINE__);           throw DialogUsage::Exception("Can't provide an offer", __FILE__,__LINE__);
# Line 375  Line 375 
375  void  void
376  InviteSession::targetRefresh(const NameAddr& localUri)  InviteSession::targetRefresh(const NameAddr& localUri)
377  {  {
378     if (isConnected()) // !slg! likely not safe in any state except Connected - what should behaviour be if state is ReceivedReinvite?     if (isConnected()) // ?slg? likely not safe in any state except Connected - what should behaviour be if state is ReceivedReinvite?
379     {     {
380        // !jf! add interface to Dialog        // !jf! add interface to Dialog
381        //mDialog.setLocalContact(localUri);        //mDialog.setLocalContact(localUri);
# Line 397  Line 397 
397        throw UsageUseException("Attempted to send overlapping refer", __FILE__, __LINE__);        throw UsageUseException("Attempted to send overlapping refer", __FILE__, __LINE__);
398     }     }
399    
400     if (isConnected()) // !slg! likely not safe in any state except Connected - what should behaviour be if state is ReceivedReinvite?     if (isConnected()) // ?slg? likely not safe in any state except Connected - what should behaviour be if state is ReceivedReinvite?
401     {     {
402        mSentRefer = true;        mSentRefer = true;
403        SipMessage refer;        SipMessage refer;
# Line 427  Line 427 
427        throw UsageUseException("Attempted to send overlapping refer", __FILE__, __LINE__);        throw UsageUseException("Attempted to send overlapping refer", __FILE__, __LINE__);
428     }     }
429    
430     if (isConnected())  // !slg! likely not safe in any state except Connected - what should behaviour be if state is ReceivedReinvite?     if (isConnected())  // ?slg? likely not safe in any state except Connected - what should behaviour be if state is ReceivedReinvite?
431     {     {
432        mSentRefer = true;        mSentRefer = true;
433        SipMessage refer;        SipMessage refer;
434        mDialog.makeRequest(refer, REFER);        mDialog.makeRequest(refer, REFER);
435    
436        refer.header(h_ReferTo) = referTo;        refer.header(h_ReferTo) = referTo;
437        refer.header(h_ReferredBy) = mDialog.mLocalContact; // !slg! is it ok to do this - should it be an option?        refer.header(h_ReferredBy) = mDialog.mLocalContact; // ?slg? is it ok to do this - should it be an option?
438        CallId replaces;        CallId replaces;
439        DialogId id = sessionToReplace->mDialog.getId();        DialogId id = sessionToReplace->mDialog.getId();
440        replaces.value() = id.getCallId();        replaces.value() = id.getCallId();
# Line 457  Line 457 
457  {  {
458     if (mNitState == NitComplete)     if (mNitState == NitComplete)
459     {     {
460        if (isConnected())  // !slg! likely not safe in any state except Connected - what should behaviour be if state is ReceivedReinvite?        if (isConnected())  // ?slg? likely not safe in any state except Connected - what should behaviour be if state is ReceivedReinvite?
461        {        {
462           mNitState = NitProceeding;           mNitState = NitProceeding;
463           SipMessage info;           SipMessage info;
# Line 639  Line 639 
639    
640        case OnUpdate:        case OnUpdate:
641        {        {
642           // !slg! no sdp in update - just responsd immediately (likely session timer) - do we need a callback?           // ?slg? no sdp in update - just responsd immediately (likely session timer) - do we need a callback?
643           SipMessage response;           SipMessage response;
644           mLastSessionModification = msg;           mLastSessionModification = msg;
645           mDialog.makeResponse(response, mLastSessionModification, 200);           mDialog.makeResponse(response, mLastSessionModification, 200);
# Line 721  Line 721 
721           else           else
722           {           {
723              // Response must contact Min_SE - if not - just ignore              // Response must contact Min_SE - if not - just ignore
724              // !slg! callback?              // ?slg? callback?
725              transition(Connected);              transition(Connected);
726              mProposedLocalSdp.release();              mProposedLocalSdp.release();
727           }           }
# Line 768  Line 768 
768    
769        case On1xx:        case On1xx:
770        case On1xxEarly:        case On1xxEarly:
771           // !slg! Some UA's send a 100 response to a ReInvite - just ignore it           // Some UA's send a 100 response to a ReInvite - just ignore it
772           break;           break;
773    
774        case On2xxAnswer:        case On2xxAnswer:
# Line 807  Line 807 
807           else           else
808           {           {
809              // Response must contact Min_SE - if not - just ignore              // Response must contact Min_SE - if not - just ignore
810              // !slg! callback?              // ?slg? callback?
811              transition(Connected);              transition(Connected);
812              mProposedLocalSdp.release();              mProposedLocalSdp.release();
813           }           }

Legend:
Removed from v.4691  
changed lines
  Added in v.5001

webmaster AT resiprocate DOT org
ViewVC Help
Powered by ViewVC 1.1.27